jbrechtel/qmk_firmware
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "[Keyboard] Remove i2c write command when reading columns on Ergodox EZ (#8092)"

Browse Source 
This reverts commit 737d2793a6ecd6ca9355a92019c8e47cc3f0c4c5.
This commit is contained in:
Drashna Jaelre
2020-02-24 16:47:19 -08:00
committed by Florian Didron
parent ca79f45ea8
commit a8e1406574
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
keyboards/ergodox_ez/matrix.c
View File

@@ -216,8 +216,10 @@ static matrix_row_t read_cols(uint8_t row) {
return 0; return 0;
} else { } else {
uint8_t data = 0; uint8_t data = 0;
// reading GPIOB (column port) since in mcp23018's sequential mode mcp23018_status = i2c_start(I2C_ADDR_WRITE, ERGODOX_EZ_I2C_TIMEOUT);
// it is addressed directly after writing to GPIOA in select_row() if (mcp23018_status) goto out;
mcp23018_status = i2c_write(GPIOB, ERGODOX_EZ_I2C_TIMEOUT);
if (mcp23018_status) goto out;
mcp23018_status = i2c_start(I2C_ADDR_READ, ERGODOX_EZ_I2C_TIMEOUT); mcp23018_status = i2c_start(I2C_ADDR_READ, ERGODOX_EZ_I2C_TIMEOUT);
if (mcp23018_status) goto out; if (mcp23018_status) goto out;
mcp23018_status = i2c_read_nack(ERGODOX_EZ_I2C_TIMEOUT); mcp23018_status = i2c_read_nack(ERGODOX_EZ_I2C_TIMEOUT);