Align our subprocess usage with current best practices. (#12940)

* Align our subprocess usage with current best practices. * remove unused import * Apply suggestions from code review Co-authored-by: Ryan <fauxpark@gmail.com> * fix the cpp invocation for older python * allow for unprompted installation * make sure qmk new-keyboard works on windows Co-authored-by: Ryan <fauxpark@gmail.com>
2021-05-19 15:24:46 -07:00
parent a9aec546c8
commit db1eacdaac
22 changed files with 70 additions and 78 deletions
@@ -4,7 +4,7 @@ _qmk_install() {
    echo "Installing dependencies"

    # TODO: Check whether devel/headers packages are really needed
-    sudo dnf -y install \
+    sudo dnf $SKIP_PROMPT install \
        clang diffutils git gcc glibc-headers kernel-devel kernel-headers make unzip wget zip \
        python3 \
        avr-binutils avr-gcc avr-libc \