From a70cd86afdb226421e253feee1e39b9578f8373c Mon Sep 17 00:00:00 2001 From: James Brechtel Date: Tue, 19 May 2026 22:54:46 -0400 Subject: [PATCH] fix: hlint warnings in SchemaOrg module - Remove unused DeriveGeneric pragma - Use newtype for SchemaOrgPerson and SchemaOrgImageObject - Remove redundant brackets around string literal --- src/Roux/SchemaOrg.hs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/Roux/SchemaOrg.hs b/src/Roux/SchemaOrg.hs index ce7142f..6b4ea57 100644 --- a/src/Roux/SchemaOrg.hs +++ b/src/Roux/SchemaOrg.hs @@ -1,4 +1,3 @@ -{-# LANGUAGE DeriveGeneric #-} {-# LANGUAGE OverloadedStrings #-} module Roux.SchemaOrg ( @@ -50,14 +49,14 @@ data SchemaOrgRecipe = SchemaOrgRecipe deriving stock (Eq, Show) -- | A schema.org Person (recipe author). -data SchemaOrgPerson = SchemaOrgPerson - { soPersonName :: !Text +newtype SchemaOrgPerson = SchemaOrgPerson + { soPersonName :: Text } deriving stock (Eq, Show) -- | A schema.org ImageObject (recipe image). -data SchemaOrgImageObject = SchemaOrgImageObject - { soImageObjectUrl :: !Text +newtype SchemaOrgImageObject = SchemaOrgImageObject + { soImageObjectUrl :: Text } deriving stock (Eq, Show) @@ -258,7 +257,7 @@ buildIngredientSection :: [Text] -> Section buildIngredientSection ings | null ings = Section Nothing (SecStep (Step []) :| []) | otherwise = - let items = concatMap (\t -> [StepText (", "), StepText t]) ings + let items = concatMap (\t -> [StepText ", ", StepText t]) ings step = Step items in Section (Just "Ingredients") (SecStep step :| [])